fix(label-known-issues): clean up tempfiles - #720
Merged
mergify[bot] merged 1 commit intoSep 25, 2026
Merged
Conversation
Motivation: Ensure that temporary files created by `openqa-label-known-issues` are reliably and automatically deleted after test executions and script runs. Design Choices: Replaced manual `tempfile.mkstemp` and `unlink` with `contextlib.ExitStack` and `tempfile.NamedTemporaryFile` utilizing automated context management. Benefits: Prevents leftover `/tmp` pollution and simplifies resource management. Related issue: os-autoinst#717
perlpunk
approved these changes
Sep 24, 2026
asmorodskyi
approved these changes
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
Ensure that temporary files created by
openqa-label-known-issuesarereliably and automatically deleted after test executions and script runs.
Design Choices:
Replaced manual
tempfile.mkstempandunlinkwithcontextlib.ExitStackand
tempfile.NamedTemporaryFileutilizing automated context management.Benefits:
Prevents leftover
/tmppollution and simplifies resource management.Related issue: #717