Make macro dependencies alias-safe#1052
Open
danieleades wants to merge 2 commits into
Open
Conversation
danieleades
marked this pull request as ready for review
July 21, 2026 08:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
typifyre-exports when usingimport_types!typify, including dependency aliasesmacrofeature and disable that feature for generator-only workspace consumerstypifyand declares no peer dependenciesContext
This follows the approach proposed by @jeffs in #1009 and makes it comprehensive. That PR handled
regress(only) this version applies the same policy tochrono,regress,serde,serde_json, anduuid, while also accounting for Cargo dependency aliases and Serde derive expansion.Generated code previously used hard-coded absolute crate paths. Macro consumers therefore needed direct dependencies on Typify's implementation crates, and routing through
::typifyalone would fail when the package was imported under a different name.Standalone
TypeSpace,build.rs, andcargo-typifyoutput retains the existing direct crate paths.User impact
Consumers of
typify::import_types!only need to declaretypifyfor built-in generated types. Renaming that dependency inCargo.tomlis supported. User-specified replacement types, conversions, and additional derives still require their own dependencies.