Repository navigation
viewer: render live scenes in any browser app, proven by a packed fixture - #1250
Merged
Merged
Conversation
wass08
force-pushed
the
viewer/render-entry
branch
from
November 10, 2026 12:47
1bc8b3d to
5e7fd8e
Compare
wass08
force-pushed
the
viewer/live-portability
branch
from
November 10, 2026 12:48
affad35 to
14bacf8
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
…ture
Slice 1b of the render-only entry: an external Vite app installing the
packed @pascal-app/core, viewer and nodes, with no editor and no Next in
its tree, hydrates a scene graph and renders it live with renderPlugin.
- configureViewer({ assetsBaseUrl, storageUrl, decoders }) replaces
module-evaluation process.env reads; defaults keep today's behaviour
and the standalone editor passes its environment explicitly
- Draco and Basis decoder directories are configurable through every
loader; Basis is pinned instead of drei-assets@master
- remaining render-path environment reads are guarded, so no process
polyfill is needed
- the Viewer's canvas background, transition and GPU fallback use inline
styles, so they render without Tailwind
- viewer preferences tolerate denied storage
- the viewer README and viewer-isolation page document the boot sequence
and the one-active-scene-per-page limit
- fixtures/viewer-live + scripts/check-viewer-live-fixture.ts pack the
three packages, install them outside the repo, assert neither the
editor nor next is installed, build with Vite, and check dev and
preview (storage available and denied) reach scene-ready with geometry
for every node, draw calls and no page errors; runs in CI
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
wass08
force-pushed
the
viewer/live-portability
branch
from
November 10, 2026 13:01
14bacf8 to
8a0b7e0
Compare
CI forces colour output and Vite then wraps the port of its printed URL in escape codes, so the fixture never found the server. Spawn servers with colour off and strip escape codes before matching. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ure time From CI and Bugbot on the live-portability PR. - a `typeof process` guard runs in the browser, where process is absent, so packed Vite production builds took the development branch (empty-draw warnings, ?stockEvents, system and clipping diagnostics). One core helper, isDevelopmentBuild, reads process.env.NODE_ENV directly, which bundlers replace with a constant, and treats an unbundled browser as production - the fixture builds its colour-code regex from the escape character instead of a control character in a literal - the packed fixture job gets 15 minutes instead of 5 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
On CI the fixture passed in 129 s and then hung until the job timeout: killing `npm run` left its Vite and esbuild children running on Linux. Servers now run in their own process group, which is stopped as a whole, and the script exits once it has printed its verdict. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit dc479a7. Configure here.
From Bugbot: the forced exit only ran after a pass, so a failing fixture still waited out the job timeout on leftover handles. Failures now print the error and exit 1. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Makes the render-only entry from #1246 usable from any browser app. An external Vite app that installs the packed
@pascal-app/core,@pascal-app/viewerand@pascal-app/nodes, with no@pascal-app/editorand nonextin its tree, can now hydrate a scene graph and render it live withrenderPluginand<Viewer>. Stacked on #1246.configureViewer({ assetsBaseUrl, storageUrl, decoders })replaces module-evaluationprocess.envreads. Defaults keep today's behaviour;apps/editorpasses its environment explicitly.drei-assets@master.processpolyfill.wiki/architecture/viewer-isolation.mddocument the boot sequence and the one-active-scene-per-page limit.fixtures/viewer-liveandbun run check:viewer-livepack the three packages, install them outside the repo with npm, and assert neither the editor nornextis installed. They then build with Vite, and checkvite devandvite preview, with storage available and denied, reach scene-ready with geometry for every node (walls, door, window, roof, ceiling with a procedural downlight cut, zone, measurement, separator, a GLTF item), draw calls and no page errors. A separate CI job runs it.How to test
bun run check:viewer-live: about 45 s; prints the isolation check, the Vite build and four browser runs (dev and preview, storage available and denied), each with geometry for every node and its draw-call count.bun run check:render-bundle: still passes.Screenshots / screen recording
N/A: no visual change in the editor. The fixture is verified headlessly (SwiftShader) in dev and production builds.
Checklist
bun devbun checkto verify)mainbranch🤖 Generated with Claude Code
Note
Medium Risk
Touches core rendering config (asset URLs, decoders, env detection) and viewer persistence; mitigated by new isolated fixture CI and existing render-bundle check.
Overview
Enables embedding the live Pascal viewer in ordinary React apps (e.g. Vite) without Next.js, Tailwind, or
@pascal-app/editor. Hosts callconfigureViewerfor asset CDN, storage, and Draco/Basis decoder paths; URL resolution and loaders read config at use time instead of baking inprocess.env, so browser bundles do not need aprocesspolyfill.isDevelopmentBuild/isDevelopmentOutsideTestsin core replace fragileNODE_ENVguards in polygon clipping and derived-node warnings. The viewer canvas background and unsupported-GPU fallback move to inline styles; viewer preferences persist through storage-safe accessors that tolerate deniedlocalStorage. The editor bootstrap explicitly passes its public CDN/Supabase URLs viaconfigureViewer.Adds
fixtures/viewer-live, root scriptcheck:viewer-live, and a CIviewer-livejob that packs@pascal-app/core,@pascal-app/viewer, and@pascal-app/nodes, installs them in an isolated npm tree, asserts no Next/editor dependency, and Playwright-smokes Vite dev/preview for scene-ready geometry and draw calls (with and without storage). README andwiki/architecture/viewer-isolation.mddocument the boot sequence and one-active-scene-per-page limit.Reviewed by Cursor Bugbot for commit b4c04cd. Bugbot is set up for automated code reviews on this repo. Configure here.