Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
CLA signatures confirmedAll contributors have signed the Contributor License Agreement. |
Author
|
@PasteurBot I have read the CLA Document and I hereby sign the CLA |
1 similar comment
Author
|
@PasteurBot I have read the CLA Document and I hereby sign the CLA |
dalyathan
marked this pull request as ready for review
October 31, 2026 01:51
dalyathan
requested review from
apaleyes,
dionhaefner,
jpbrodrick89 and
xalelax
as code owners
October 31, 2026 01:51
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relevant issue or PR
Fixes #883
Description of changes
Loading
tesseract_api.pywrote the runtime's wholesys.pathintoPYTHONPATH, so every subprocess started from it inherited the runtime's stdlib and site-packages. A child running the same interpreter doesn't notice, but a different Python imports the runtime's modules instead of its own. With a 3.14 runtime, a Python 3.11 started fromapplydies on start-up:load_module_from_pathnow exports only the module directory, ahead of any existingPYTHONPATH, and restores the previous value if loading fails. Children can still importtesseract_api.pyand its sibling modules, and thesys.modulesregistration from #488 is unchanged.Testing done
test_subprocesses_inherit_only_module_dir_on_pythonpathchecks thePYTHONPATHa child process sees, with and without an outerPYTHONPATH. Onmainthe child gets the runtime's fullsys.path.test_load_module_from_path_restores_pythonpath_on_failurecovers the failure path. Both fail onmainand pass with this change.mainand runs with this change.ProcessPoolExecutorintesseract_api.py#356 case (a spawnProcessPoolExecutorinapplymapping a function fromtesseract_api.pyand one from a sibling module) gives the same result before and after.pytest --skip-endtoendpasses locally (Python 3.14, without the jax extras). Not run: the end-to-end Docker tests and Python 3.10.🤖 Generated with Claude Code