FISH-13937 fixes #8001 Fix RandomAccessFile leak in FilePool.close() - #8002
Open
iamsanjaymalakar wants to merge 1 commit into
Open
iamsanjaymalakar wants to merge 1 commit into
iamsanjaymalakar wants to merge 1 commit into
Conversation
Pandrex247
added
the
PR: Awaiting CLA
Author
|
Emailed the signed CLA. |
Member
|
@deetewari Can you verify the CLA please? I don't have access to that mailbox |
Pandrex247
changed the title
Author
Any updates? |
MeroRai
added
PR: CLA
iamsanjaymalakar
force-pushed
the
issue-8001
branch
from
August 31, 2026 19:11
5831eaf to
898e2ac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix resource cleanup in RandomAccessDataFile.FilePool#close().
If closing one pooled RandomAccessFile throws an IOException, the current loop exits early and remaining pooled files may remain unclosed. This change continues closing the rest and then rethrows the first exception (with subsequent ones suppressed).
Addresses: #8001
Important Info
Blockers
None.
Testing
New tests
None.
Built the affected module locally.
Notes for Reviewers
Change is limited to FilePool#close() and only affects the failure path when RandomAccessFile.close() throws.