Images update with VeloC - #29
Open
iole-bolognesi wants to merge 66 commits into
Open
Conversation
…updated action, not pdidev/.. action
…bility issue between doxygen and spdlog
iole-bolognesi
marked this pull request as ready for review
June 11, 2026 12:33
… with shared mem support, include git in the temporary velocdl stage, remove use of pip to download tools needed to install veloc, install veloc in /opt/veloc
…libcurl4-openssl-dev in some distributions like jammy
jmorice91
reviewed
Aug 6, 2026
jmorice91
left a comment
jmorice91
left a comment
Contributor
There was a problem hiding this comment.
I request only change on the exclude comment.
A similar work is done for catalyst plugin because we need a minimal cmake version to add this plugin in the image.
Comment on lines
+17
to
+21
| # exclude debian/unstable + mpich as debian/unstable mpich package | ||
| # does not allow building with shared mem support needed by VeloC | ||
| exclude: | ||
| - { base: 'debian/unstable', mpi: mpich, variant : all} | ||
| - { base: 'debian/unstable', mpi: mpich, variant : mini} |
Contributor
There was a problem hiding this comment.
We want to test pdi and its plugins not only veloc plugin.
If veloc plugin doesn't support some env, it is better to exclude these case in the Dockerfile use to generate the image.
using: ARG DISTRO, ARG DISTRO_VERSION and ARG MPI
| python3-bs4 \ | ||
| && rm -rf /var/lib/apt/lists/* | ||
|
|
||
| WORKDIR /opt/src |
Contributor
There was a problem hiding this comment.
@pdidev/pdi-maintainers Do you want to adopt the convention '/opt/src/' at the source file for third-party software?
|
|
||
| COPY --from=velocdl /opt/veloc /opt/veloc | ||
|
|
||
| ENV CMAKE_PREFIX_PATH=/opt/veloc:${CMAKE_PREFIX_PATH} |
Contributor
There was a problem hiding this comment.
What is the value of CMAKE_PREFIX_PATH before this line?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.