Skip to content

⚡ Optimize small unique_rolls with fast bitmask #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
perim wants to merge 1 commit into from
Closed

⚡ Optimize small unique_rolls with fast bitmask #19

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions dice.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,6 +228,7 @@ int roll_table::unique_rolls(int count, int* results, luck_type rollee_luck, int
int seen_capacity = 256;
int seen_mask = 255;
std::vector<int> heap_seen;
uint64_t fast_mask = 0;

if (use_set)
{
Expand Down Expand Up @@ -259,6 +260,13 @@ int roll_table::unique_rolls(int count, int* results, luck_type rollee_luck, int
seen[h] = k;
}
}
else
{
for (int j = 0; j < start_index; j++)
{
fast_mask |= (1ULL << (results[j] & 63));
}
}

for (int i = 0; i < count; i++)
{
Expand All @@ -278,10 +286,14 @@ int roll_table::unique_rolls(int count, int* results, luck_type rollee_luck, int
}
else
{
for (int j = 0; j < start_index + i; j++)
if (fast_mask & (1ULL << (k & 63)))
{
if (results[j] == k) goto repeat;
for (int j = 0; j < start_index + i; j++)
{
if (results[j] == k) goto repeat;
}
}
fast_mask |= (1ULL << (k & 63));
}
results[start_index + i] = k;
}
Expand Down
Loading