Skip to content

⚡ Optimize const_roll_table::roll hot path - #24

Merged
perim merged 1 commit into
mainfrom
perf-optimization-dice-h-833052734268679771
Aug 12, 2026
Merged

perim merged 1 commit into
mainfrom
perf-optimization-dice-h-833052734268679771

Conversation

@perim

@perim perim commented Aug 12, 2026

Copy link
Copy Markdown
Owner

💡 What: Replaced std::vector::at() with the array subscript operator [] for accessing probability and alias elements in const_roll_table::roll (dice.h:117).
🎯 Why: The at() method includes an bounds check on every access, which adds unnecessary overhead in a hot path. Since the index i is deterministically generated to be strictly within the bounds [0, size - 1], the bounds check is redundant. Using [] avoids this overhead, making the method faster.
📊 Measured Improvement:

  • Baseline performance for 400,000 rolls of const_roll_table: ~4,182,454 cycles.
  • Optimized performance for 400,000 rolls: ~3,863,542 cycles.
  • Improvement: Reduced cycle count by ~318,912 cycles (~7.6% improvement in the CRT benchmark).

PR created automatically by Jules for task 833052734268679771 started by @perim

Co-authored-by: perim <436583+perim@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@perim
perim merged commit c77d5d2 into main Aug 12, 2026
1 check passed
@perim
perim deleted the perf-optimization-dice-h-833052734268679771 branch August 12, 2026 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant