Wait for the server ack when leaving channels - #6792
Closed
patric-vinicios wants to merge 1 commit into
Closed
Conversation
SteffenDE
reviewed
Aug 18, 2026
Comment on lines
-1044
to
-1047
| // TODO - the following tests are skipped until Channel.leave | ||
| // behavior can be fixed; currently, 'ok' is triggered immediately | ||
| // within Channel.leave so timeout callbacks are never reached | ||
| // |
Member
There was a problem hiding this comment.
Since this behavior has been the same since the beginning, I'm inclined to keep it and only change it when we do a 2.0 release.
Member
|
Closing as per the above. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran into this while looking at channel cleanup in an app
leave()was returning"ok"before the server had actually replied.leave()changes the channel state toleavingand then checkscanPush(), butcanPush()only returns true when the channel is still joined so at that point it always returnsfalseThen, the fallback runs right away and the channel closes locally instead of waiting for the server reply or the leave timeout
The fix is just to check
canPush()before changing the state toleavingIf the channel can still push, it sends the leave request and waits for either the reply or the timeout. If it cant, it keeps the existing behavior and closes immediately
I also re-enabled the tests for the leaving state and leave timeout
Tested with:
npm test -- --runInBandnpx eslint assets/js/phoenix/channel.js assets/test/channel_test.js