Conversation
ndossche
requested changes
Sep 18, 2026
Comment on lines
203
to
207
| smart_str_0(&retval); | ||
| if (!retval.s) { | ||
| return ZSTR_EMPTY_ALLOC(); | ||
| } | ||
| return retval.s; |
Member
There was a problem hiding this comment.
This entire block should be replaced with:
Suggested change
| smart_str_0(&retval); | |
| if (!retval.s) { | |
| return ZSTR_EMPTY_ALLOC(); | |
| } | |
| return retval.s; | |
| return smart_str_extract(&retval); |
The prompt parser ran as a do-while, so an empty cli.prompt executed the body on the terminator and scanned past it. Use a while loop and smart_str_extract(), which returns the interned empty string when nothing was appended. No regression test: extra unicode warnings from the over-read depend on heap contents, so a .phpt cannot pin the bug red-before. Closes phpGH-23415
iliaal
force-pushed
the
fix/readline-cli-prompt-empty
branch
from
September 18, 2026 19:49
78a6f6a to
0401773
Compare
ndossche
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cli_get_prompt() parsed cli.prompt with a do-while, so the empty string executed the body on the terminator and scanned heap past it. Use a while loop and return the interned empty string when nothing was appended.