Conversation
Girgias
approved these changes
Sep 16, 2026
…rg specifier I misremembered the correct syntax for specifying the argnum in an `sprintf()` format string and placed the number after the `$` instead of before. This lead to `sprintf()` seeing an empty number and reporting: > Argument number specifier must be greater than zero and less than 2147483647 which was misleading. Had the error message shown that the argnum is empty, it would have been much clearer that it expect the number before the `$`.
TimWolla
force-pushed
the
sprintf-empty-argnum-better-error
branch
from
September 16, 2026 11:00
2f1d35e to
8ce5513
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I misremembered the correct syntax for specifying the argnum in an
sprintf()format string and placed the number after the$instead of before. This lead tosprintf()seeing an empty number and reporting:which was misleading. Had the error message shown that the argnum is empty, it would have been much clearer that it expect the number before the
$.