Add NULL check on zend_hash_index_find() return value in extract_token_id_to_replace() - #23707
Closed
ushevchenko wants to merge 1 commit into
Closed
ushevchenko wants to merge 1 commit into
ushevchenko wants to merge 1 commit into
Conversation
Problem: Return value of zend_hash_index_find() is dereferenced in extract_token_id_to_replace() without checking for NULL. Solution: added NULL check for text_zv before dereference. Signed-off-by: u.shevchenko@fobos-nt.ru Signed-off-by: crystarm@altlinux.org
Member
|
These tokens arrays are created by this extension and is always an array of 3 elements; so this is a bogus bug report. But note that even if this were not the case then this patch doesn't make much sense as you'd have to signal to userland that something went wrong. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #23704
Adds a NULL check on the return value of zend_hash_index_find() in extract_token_id_to_replace() (ext/tokenizer/tokenizer.c), consistent with how this function's return value is checked at other call sites in the codebase, and consistent with how this same function already returns NULL for other malformed-input cases. See the linked issue for details — this was flagged by static analysis (statistical NULL-deref checker), not by an observed crash.