Skip to content

Contentstack package: Add limit and order to fetcher - #54

Closed
Thomas-Wesley-BSA wants to merge 3 commits into
plasmicapp:masterfrom
Thomas-Wesley-BSA:CS-limit
Closed

Thomas-Wesley-BSA wants to merge 3 commits into
plasmicapp:masterfrom
Thomas-Wesley-BSA:CS-limit

Conversation

@Thomas-Wesley-BSA

Copy link
Copy Markdown

No description provided.

@vercel

vercel Bot commented Sep 26, 2022 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
contenful-example ✅ Ready (Inspect) Visit Preview Oct 19, 2022 at 4:13AM (UTC)
dynamic-multistep-forms ✅ Ready (Inspect) Visit Preview Oct 19, 2022 at 4:13AM (UTC)
plasmic ✅ Ready (Inspect) Visit Preview Oct 19, 2022 at 4:13AM (UTC)
plasmic-blog-example ❌ Failed (Inspect) Oct 19, 2022 at 4:13AM (UTC)
plasmic-blog-starter ❌ Failed (Inspect) Oct 19, 2022 at 4:13AM (UTC)
vercel-workflow ✅ Ready (Inspect) Visit Preview Oct 19, 2022 at 4:13AM (UTC)

@vercel

vercel Bot commented Sep 26, 2022

Copy link
Copy Markdown

@Thomas-Wesley-BSA is attempting to deploy a commit to the Plasmic Team on Vercel.

A member of the Team first needs to authorize it.

@yang

yang commented Sep 29, 2022

Copy link
Copy Markdown
Contributor

Very cool!

@yang
yang requested review from guitubone and samuelfgs September 29, 2022 20:08
@Thomas-Wesley-BSA
Thomas-Wesley-BSA marked this pull request as draft October 10, 2022 05:31
@Thomas-Wesley-BSA

Copy link
Copy Markdown
Author

More wanted functionality came up at work today - namely ability to choose which field to match on for the "Entry UID" prop, with the current behavior (UID) being the default.

We want to use dynamic paths to pull a single entry, and this will let us use url/pretty-custom-slug instead of url/4f7ds89a7gre

I've drafted the PR until said functionality is done, then I'll reopen it.

@Thomas-Wesley-BSA

Copy link
Copy Markdown
Author

Done. It is only meant to work properly for string fields at the moment. It would be possible to fix this in the future, as we have access to the schema so there can be different behavior for string/number/boolean/etc... But to implement that properly the prop type will need to be dynamic, which it isn't at the moment (and I imagine would be a complicated change).

@sampullman

Copy link
Copy Markdown
Contributor

Mostly fixed in 7d0e92e besides ordering. That could be done if still needed, but this is pretty old.

@sampullman sampullman closed this Oct 26, 2026
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 26, 2026

This branch had an error being deployed

2 failed and 4 active deployments
Preview – plasmic-blog-starter — ba2f6ab2 Deployed Oct 19, 2022 by vercel[bot]
Preview – plasmic-blog-example — ba2f6ab2 Deployed Oct 19, 2022 by vercel[bot]
Preview – dynamic-multistep-forms — ba2f6ab2 Deployed Oct 19, 2022 by vercel[bot]
Preview – contenful-example — ba2f6ab2 Deployed Oct 19, 2022 by vercel[bot]
Preview – vercel-workflow — ba2f6ab2 Deployed Oct 19, 2022 by vercel[bot]
Preview – plasmic — ba2f6ab2 Deployed Oct 19, 2022 by vercel[bot]
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants