Fix(Migration): prevent container name corruption on partial update#1221
Draft
stonebuzz wants to merge 1 commit into
Draft
Fix(Migration): prevent container name corruption on partial update#1221stonebuzz wants to merge 1 commit into
stonebuzz wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Please delete options that are not relevant.
Description
During plugin installation when migrating containers from GenericObject to
CustomAsset, containers end up with a corrupted
namefield (e.g.sixonefourfourthreesixtwozeroeight) and an emptylabel, causing asubsequent MySQL error when the dynamic table name exceeds 64 characters.
Root cause
installBaseDatacallsupdate()with onlyidanditemtypes(nolabelkey to update) see L249prepareInputForUpdate()calledprepareLabel()unconditionally, which:''togetSystemNameFromLabel(), which fell back torandom_int(0, mt_getrandmax())for an empty namereplaceIntByLetters(), spelling eachdigit out (
6 1 4 4 3 6 2 0 0 8=>sixonefourfourthreesixtwozeroeight)State before migration
mysql> SELECT id, name, label, itemtypes FROM glpi_plugin_fields_c
+----+---------+---------+--------------------------------+
| id | name | label | itemtypes |
+----+---------+---------+--------------------------------+
| 3 | contain | contain | ["PluginGenericobjectContain"] |
+----+---------+---------+--------------------------------+
State after migration (buggy)
+----+------------------------------------+-------+-------------------------------------+
| id | name | label | itemtypes
+----+------------------------------------+-------+-------------------------------------+
| 3 | sixonefourfourthreesixtwozeroeight | | ["Glpi\CustomA
+----+------------------------------------+-------+-------------------------------------+
This triggers:
RuntimeException: MySQL query error: Identifier name
'glpi_plugin_fields_glpicustomassetcontainassetsixonefourfourthree
is too long (1059)