Add cmath header for mathematical functions (e.g. std::isfinite())#3
Open
rpw wants to merge 1 commit into
Open
Add cmath header for mathematical functions (e.g. std::isfinite())#3rpw wants to merge 1 commit into
rpw wants to merge 1 commit into
Conversation
|
Can confirm that I had to apply this patch to build with the Nix flake. |
|
Please merge this 🙏 Forgetting to import cmath is crazy work 😭 |
|
confirmed from me too. this fixes gcc15 for me (conda-forge build chain). |
crusaderky
approved these changes
Jul 22, 2026
|
Hit the same build error on DGX Spark (CUDA 13, aarch64, sm_121). This patch fixes it. Been serving Laguna S-2.1 Q4_K_M on a single Spark with it since yesterday, no issues. Would be great to see this merged. |
|
Same on Strix Halo Ubuntu building poolsideai/llama.cpp both vulkan / ROCm backends. Added the line and we are off to the races |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fix compile error with gcc 15.2.0:
Requirements