Skip to content

apt_info: don't crash where phasing_applied is missing #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Bierchermuesli wants to merge 1 commit into
base: master
Choose a base branch
from
Open

apt_info: don't crash where phasing_applied is missing #272

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions apt_info.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,17 @@

_UpgradeInfo = collections.namedtuple("_UpgradeInfo", ["labels", "count"])

# python-apt exposes the phased updates API since 2.7.11. Older releases --
# Debian 12 (2.6.0) and Ubuntu 22.04 (2.4.0) -- raise AttributeError for every
# package, which aborts the script before it writes any metric. Probe for the
# attribute instead of comparing versions: Ubuntu 24.04 backported the API into
# its 2.7.7.
_HAS_PHASING = hasattr(apt.package.Package, "phasing_applied")


def _phasing_applied(package):
return package.phasing_applied if _HAS_PHASING else False


def _convert_candidates_to_upgrade_infos(candidates):
changes_dict = collections.defaultdict(lambda: collections.defaultdict(int))
Expand Down Expand Up @@ -65,7 +76,7 @@ def _write_pending_upgrades(registry, cache, exclusions):
candidates = {
p.candidate
for p in cache
if p.is_upgradable and not p.phasing_applied and p.name not in exclusions
if p.is_upgradable and not _phasing_applied(p) and p.name not in exclusions
}
for candidate in candidates:
logging.debug(
Expand All @@ -90,7 +101,7 @@ def _write_held_upgrades(registry, cache, exclusions):
if (
p.is_upgradable
and p._pkg.selected_state == apt_pkg.SELSTATE_HOLD
and not p.phasing_applied
and not _phasing_applied(p)
and p.name not in exclusions
)
}
Expand Down
Loading