Fix map tests failing on single-CPU systems - #213
Conversation
With GOMAXPROCS=1, numGoroutines/2 evaluates to 0 in TestMapParallelRangeRelaxed and TestMapParallelDeleteMatching, so no goroutines are started and the "expected some iterations/deletions" checks fail. Start at least one goroutine of each kind. Fixes #212
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #213 +/- ##
=======================================
Coverage 99.54% 99.54%
=======================================
Files 7 7
Lines 875 875
=======================================
Hits 871 871
Misses 4 4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Fixes #212
With GOMAXPROCS=1, numGoroutines/2 evaluates to 0 in
TestMapParallelRangeRelaxedandTestMapParallelDeleteMatching, so no goroutines are started and the "expected some iterations/deletions" checks fail. Start at least one goroutine of each kind.