Skip to content

Fix map tests failing on single-CPU systems - #213

Merged
puzpuzpuz merged 2 commits into
mainfrom
fix-single-cpu-tests
Sep 27, 2026
Merged

puzpuzpuz merged 2 commits into
mainfrom
fix-single-cpu-tests

Conversation

@puzpuzpuz

Copy link
Copy Markdown
Owner

Fixes #212

With GOMAXPROCS=1, numGoroutines/2 evaluates to 0 in TestMapParallelRangeRelaxed and TestMapParallelDeleteMatching, so no goroutines are started and the "expected some iterations/deletions" checks fail. Start at least one goroutine of each kind.

With GOMAXPROCS=1, numGoroutines/2 evaluates to 0 in
TestMapParallelRangeRelaxed and TestMapParallelDeleteMatching, so
no goroutines are started and the "expected some iterations/deletions"
checks fail. Start at least one goroutine of each kind.

Fixes #212
@puzpuzpuz puzpuzpuz self-assigned this Sep 27, 2026
@puzpuzpuz puzpuzpuz added bug Something isn't working tests labels Sep 27, 2026
@coderabbitai

coderabbitai Bot commented Sep 27, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: f19058f5-30b9-41bc-96d9-aadba962c836

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov-commenter

codecov-commenter commented Sep 27, 2026 •

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.54%. Comparing base (34300af) to head (1426dd3).
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #213   +/-   ##
=======================================
  Coverage   99.54%   99.54%           
=======================================
  Files           7        7           
  Lines         875      875           
=======================================
  Hits          871      871           
  Misses          4        4           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@puzpuzpuz
puzpuzpuz merged commit 8a8c7d3 into main Sep 27, 2026
5 checks passed
@puzpuzpuz
puzpuzpuz deleted the fix-single-cpu-tests branch September 27, 2026 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Some tests do not work on single-CPU systems

2 participants