Feature: Add Positive and Negative EIS calculation - #5648
Open
Ombrini wants to merge 7 commits into
Open
Conversation
Brings in the Read the Docs fix (pybamm-team#5659), which fetches the SUNDIALS/SuiteSparse submodules so pybammsolvers builds from source. Resolves the CHANGELOG.md conflict by keeping the three-electrode EIS entry alongside the new upstream entries, and corrects its PR link.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds three-electrode EIS support to
pybamm.EISSimulation.When
three_electrodes=True,EISSimulationnow inserts a default reference electrode at the separator midpoint if one has not already been inserted. The EIS setup promotes the positive and negative 3E potentials to algebraic probe variables, returns named impedance components in theEISSolution, and keeps the defaultsolution.impedanceas the cell impedance.EISSolution.nyquist_plot()now detects three-electrode impedance components and plots the cell, positive electrode, and negative electrode curves together.Type of change
Feature.
Important checks:
Please confirm the following before marking the PR as ready for review:
nox -s pre-commitnox -s testsnox -s doctests