Repository navigation
Skip unit normalization for near-zero vectors to avoid NaN - #74
Merged
Merged
Conversation
jessegrabowski
force-pushed
the
mclmc-grad-floor
branch
from
July 28, 2026 15:30
0f00482 to
27c0e62
Compare
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## main #74 +/- ##
===========================================
- Coverage 83.77% 66.88% -16.89%
===========================================
Files 8 34 +26
Lines 1923 9413 +7490
===========================================
+ Hits 1611 6296 +4685
- Misses 312 3117 +2805 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
|
Looks good, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small safety guard for MCLMC I stole from the blackjax implementation. Near the mode, the unit normalization factor of the momentum vector can be close to zero. Blackjax adds a small epsilon and passes through degenerate values without normalization here and here; ultimately consumed by the integrator here.