Repository navigation
Conversation
assert is skipped under python -O, so unregister() with no arguments returned None and unregister(unregistered_plugin) returned the plugin. Raise TypeError when neither name nor plugin is given, and ValueError when the given plugin is not registered. Fixes pytest-dev#762
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
unregister()validated its arguments withassert. Underpython -Othose checks disappear, sopm.unregister()returnedNoneandpm.unregister(unregistered_plugin)returned the plugin.Raise
TypeErrorwhen neitherpluginnornameis given, andValueErrorwhen the given plugin object is not registered. The existingname=path still returnsNonewhen the name is unknown.Fixes #762