Repository navigation
Conversation
Keep equal-valued plugin instances distinct during registration, name and membership lookup, and hook removal. Cover the public lifecycle with dataclass plugins and retain duplicate registration checks for the same instance. Fixes pytest-dev#760 Reported-by: RonnyPfannschmidt (GitHub) Assisted-by: OpenAI Codex (AI) Reviewed-by: GPT-6 Luna (AI)
Member
|
Closing as unattended ai |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use identity for plugin registration, membership/name lookup, and hook removal. Equal-valued instances can register separately; unregistering one preserves the other's hooks.
Fixes #760. Thanks @RonnyPfannschmidt for the report.
Tests: 224 pass on macOS/Python 3.14; all pre-commit checks pass.