Repository navigation
Reject incomplete density annotations in formula parser - #145
Open
swf1996120 wants to merge 1 commit into
Open
swf1996120 wants to merge 1 commit into
swf1996120 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This report comes from an LLM-assisted testing study of chemical software. I ran and minimized the reproducer locally against the current release and checked the repository issue tracker for duplicates.
formula("H2O@")silently accepts an incomplete density annotation and sets the formula density to1, instead of rejecting the malformed input or leaving the density unspecified.Reproducer
For comparison, malformed values such as
formula("H2O@.")andformula("H2O@1q")raise an exception, while the missing numeric value after@is interpreted as the default count1.Expected behavior
A trailing
@without a density should raise a parse error. It should not silently change the semantic value of the formula by assigning density 1.Environment
The behavior is caused by the density grammar using
number, whose optional count defaults to 1, after the literal@.