Repository navigation
Reject invalid mixture quantities - #149
Open
swf1996120 wants to merge 1 commit into
Open
swf1996120 wants to merge 1 commit into
swf1996120 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch accompanies #148.
mix_by_weight()andmix_by_volume()previously filtered material quantities withq > 0, silently treating negative or non-finite amounts as zero. That can turn a typo into a different chemical composition or an empty formula without a diagnostic.The patch validates that all relative quantities are finite and non-negative before the existing zero-quantity filtering. Zero and positive quantities preserve their current behavior. Regression tests cover negative, NaN, and infinity inputs for both mixture helpers.
Local validation:
ValueErrorand zero quantities remain accepted;compileallpasses;git diff --checkpasses.This report and patch were prepared as part of an LLM-assisted testing study of chemistry repositories. Each reproducer was run locally and minimized before filing.