Repository navigation
Handle zero-mass formula fractions - #151
Open
swf1996120 wants to merge 1 commit into
Open
swf1996120 wants to merge 1 commit into
swf1996120 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Formula.mass_fractionraisedZeroDivisionErrorfor formulas accepted by the grammar with zero element counts, such asformula("H0")andformula("C0H0").Fix
Return zero mass fractions when the total formula mass is zero, while preserving ordinary mass-fraction calculations. Add regression coverage for zero-count and normal formulas.
Closes #150
Validation
H0,C0H0, andH2Opython -m compileall -q periodictable testgit diff --checkThis patch was prepared as part of a chemical-repository testing study with LLM assistance; the reproducer and fix were run locally.