Remove flake8#333
Merged
Merged
Conversation
Collaborator
Author
|
This is mostly CI updates to keep up with the evolving ecosystem of dependencies. Merging this one and I'll send another soon to separate the images from the code so we can update them more frequently without bloating the repo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative to #332
Latest pytest broke old plugins like flake8. We don't really use that one anymore b/c all linting happens with pre-commits.
NB: I only updated images that had diff >20 tol. The goal is to reduce repo bloat by not adding png files. I'll work on a better solution where we can separate the images from the source code and download them at test time. I also dropped Python 3.10 from the tests b/c matplotlib also dropped it and it is not worth keeping CI logic to test unsupported mpl versions here.