gh-151987: Pass filter_function to TarFile._extract_one() during .extract()#151988
Open
encukou wants to merge 7 commits into
Open
gh-151987: Pass filter_function to TarFile._extract_one() during .extract()#151988encukou wants to merge 7 commits into
encukou wants to merge 7 commits into
Conversation
encukou
added
needs backport to 3.13
encukou
added
the
🔨 test-with-buildbots
|
🤖 New build scheduled with the buildbot fleet by @encukou for commit c2831a9 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F151988%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
bedevere-bot
removed
the
🔨 test-with-buildbots
StanFromIreland
approved these changes
Jun 25, 2026
| @unittest.skipUnless(hasattr(os, 'geteuid'), "missing os.geteuid") | ||
| @support.subTests('link_type', (tarfile.SYMTYPE, tarfile.LNKTYPE)) | ||
| def test_chown_links_on_extractall(self, link_type): | ||
| with ArchiveMaker() as arc: |
Member
There was a problem hiding this comment.
These could be refactored, but due to the nature of this PR I don't think we need to delay with such things.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.