Re-raise unexpected exceptions instead of swallowing them in tests#152019
Conversation
|
Nice catch! I asked Claude to search for more of these, and it came back with one more:
From a glance, it seems correct (although we're unlikely to hit it on most systems), but I think we can include it here. |
Co-authored-by: Stan Ulbrych <stan@python.org>
|
@StanFromIreland Thank you for the review, updated! |
|
🤖 New build scheduled with the buildbot fleet by @StanFromIreland for commit 2c2f096 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F152019%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
|
Looks good, but let's run the Buildbots, just to be safe, since these are all quite platform specific cases. |
|
Thanks @aisk for the PR, and @StanFromIreland for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15. |
|
GH-152102 is a backport of this pull request to the 3.15 branch. |
|
GH-152103 is a backport of this pull request to the 3.14 branch. |
|
GH-152104 is a backport of this pull request to the 3.13 branch. |
|
Merged, thanks @aisk. |
When fixing #137420, I found that some existing test code swallows exceptions it doesn't care about.
I think these are simple, test only fixes, so the issue and the news entry aren't required.