gh-151593: Avoid deadlock in insert_split_key().#152133
Closed
nascheme wants to merge 2 commits into
Closed
Conversation
We must not acquire other locks while holding the LOCK_KEYS() mutex. This issue is fixed by calling PyType_Modifed() after releasing the mutex.
Member
Author
|
This fixes the deadlock but it introduces a correctness issue: a thread can read a stale class attribute/method back from an instance attribute it just stored. The only solution I can think of for this now is to revert GH-150489. :-( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We must not acquire other locks while holding the LOCK_KEYS() mutex. This issue is fixed by calling PyType_Modifed() after releasing the mutex.
Note: this PR was assisted by Claude Opus 4.8.