search: add query_ast, counts, and warmup byte span attributes - #6588
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 248f437efe
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
248f437 to
ecb2499
Compare
ecb2499 to
a464de8
Compare
| "warmup_mb", | ||
| byte_range_cache | ||
| .get_num_bytes() | ||
| .saturating_sub(cache_bytes_before_warmup) as f64 |
There was a problem hiding this comment.
I don't think this is correct. Some of that data could have been in the fastfield cache for instance.
It kind on depends what you are interested in. If it is how much bytes are required for that task (regardless of whether it is downloaded or fetch from cache, then you just need to change the name of your field).
If you want the downloaded bytes, a metric exists at the Storage level.
| /// not propagate to log events, so it can carry verbose values (e.g. a query AST) | ||
| /// without bloating logs. No-op when no OpenTelemetry layer is installed. | ||
| pub fn record_current_span_attribute(key: &'static str, value: impl Into<opentelemetry::Value>) { | ||
| Span::current().set_attribute(key, value); |
There was a problem hiding this comment.
not he most useful helper. I would rather stick to inlining that code.
a464de8 to
607f5ee
Compare
607f5ee to
a967c44
Compare
2 participants
root_searchspan attributeswarmup_mbanddownloaded_mbas attributes on the warmup span🤖 Generated with Claude Code