fix(storage): disable crc32 trailing checksum with checksum_algorithm: md5 - #6641
Open
Totodore wants to merge 1 commit into
Open
fix(storage): disable crc32 trailing checksum with checksum_algorithm: md5#6641Totodore wants to merge 1 commit into
Totodore wants to merge 1 commit into
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9e22ce31e7
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
With the
checksum_algorithmparams set tomd5our S3 provider (Outscale) was still rejecting publish splits requests with the following error400 BadRequest: "trailing checksum is not supported".It appears that the AWS SDK was still adding its own crc32 checksum as a trailer on streamed requests.
This fix this behavior by setting
RequestChecksumCalculationtoWhenRequiredrather thanWhenSupported(which is the default) for md5/disabled checksum_algorithm option.How was this PR tested?
Tested on a dev env against the S3 provider to validate ingestion.