fix(xtask): reconcile live sweep plans with compiled tests - #254
Merged
Merged
Conversation
Ralph-Iteration: 263
CI prerequisite for iteration 263; RUSTSEC-2026-0285.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The live sweep previously counted only names found by its source scanner, so an omitted test could disappear from both the run and its totals. Reconcile each target with its compiled ignored-test inventory before planning either dry-run or real execution; fail with the names of compiled tests missing source metadata. Use the compiled inventory for host-specific inclusion, and propagate directory-entry errors.
Production-path regressions cover a dropped name, host exclusions, and agreement between reported counts and actual
--exactarguments. Both filtering and command-omission mutations fail their regressions. The historical 319/320 cause remains unproved; the plan records the permitted unsuccessful-investigation disposition and the evidence needed to reopen it.Validation
cargo fmt, strict workspace clippy, and workspace tests passed on the final source.Final dependency-state sweep used
FF_RDP_LIVE_TESTS=1 FF_RDP_LIVE_NETWORK_TESTS=1and Firefox 156.0. Dry-run and real sweep both qualified 344 tests. Exact-name reconciliation across all five tiers: 341 passed, 3 failed, with no missing, extra or duplicate verdicts (CLI332/3; core9/0).Every per-target profile scan was clean. Owned raw Firefox stopped/reaped; port6000 free.
Carry-over
live_137_consent_accept_via_daemonfailed target readiness after15,194ms/47polls. The preceding repair sweep failed after15,257ms; earlier attempts separately failed ready-target Sourcepoint action. Preserve both shapes; this runner change fixes neither.live_165_scope_behaviour_tablefailedeval typeof c1with the existing “timeout after auth” greeting-wait envelope (proxy52636). This does not prove server-side authentication succeeded; attributable timing remains unavailable.Review
Independent full review found the host-cfg mismatch; scoped review verified the runtime repair and required stronger regression tests. The final scoped review covers the production-helper/test repair and both mutation proofs. Supervisor verifies final status and evidence transcription separately.
CI prerequisite
The first PR head passed nine checks but failed supply-chain on existing
rustls 0.23.40(RUSTSEC-2026-0285). Following the repository's patch-upgrade procedure, update only rustls to0.23.45 and its required webpki to0.103.15. Independent security review found no issues; features/provider remain unchanged. Local cargo audit and cargo deny pass. Final-dependency sweep and ordered gates are recorded separately from the two completed implementation repair batches.Evidence retained locally under
.git/ralph-loop/20260919-queue/iter263*, including each attempt's logs, mutation failures, final exact-name reconciliation, gate command timestamps and browser cleanup. Actual token usage is unavailable.