Skip to content

Various fixes - #577

Merged
raxod502 merged 4 commits into
radian-software:developfrom
haji-ali:pr-fixes
Aug 19, 2026
Merged

raxod502 merged 4 commits into
radian-software:developfrom
haji-ali:pr-fixes

Conversation

@haji-ali

Copy link
Copy Markdown
Contributor

I have four fixes that I hope are OK to submit as one PR. I recommend not squashing them, as they address separate issues.

The motivations are:

  • Currently, if a file is deleted while its buffer is open, there is a chance that a directory will be created for the buffer. For me, this manifested as repeatedly deleting the directory containing an open buffer's file, only for Radian to recreate it.
  • Using when-let (unstarred) produces a compilation warning.
  • custom-file is currently loaded before any Radian variables are defined. This is the only file that is not compiled as part of Radian, so I wanted to use it to check whether Radian needs to be recompiled (for custom-related reasons). However, the Radian variables are not defined when it is loaded. Is there a reason why custom is loaded so early in Radian's initialisation cycle?
  • kill-process is asynchronous. I believe we want delete-process here to ensure that we can start a new process with the same name.

@raxod502 raxod502 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That all looks good to me! Thanks!

@raxod502
raxod502 merged commit 9ded680 into radian-software:develop Aug 19, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants