Repository navigation
[raudio] LoadSoundAlias(): check source buffer before use - #6236
Merged
Merged
Conversation
If the source sound failed to load (for example when no audio playback device could be initialized), its stream.buffer is NULL and LoadSoundAlias() dereferenced it. Check the buffer first, like UnloadSoundAlias() and IsSoundValid() already do, so an empty Sound is returned instead of crashing. Seen with examples/audio/audio_sound_multi (reported in raysan5#5664).
Owner
|
@akashdeshmukh-git thanks for the review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the source sound failed to load (for example when no audio playback device could be initialized), its
stream.bufferis NULL andLoadSoundAlias()dereferenced it. This checks the buffer first, likeUnloadSoundAlias()andIsSoundValid()already do, so an empty Sound is returned instead of crashing.This is the
audio_sound_multicrash reported in #5664. Reproduced with PLATFORM_MEMORY (no playback device) under ASan; with the fix it only logs the usual load warnings