Rebase - #34
Merged
Merged
Rebase#34
Conversation
The "ctrl" library was copied from large parts of "app" but app was not yet rewritten to use it directly. This has been done now, and the namespace of ctrl has been fixed to ctrl. Test Procedure: No functional changes; build only.
Certain product variants have had a patch for subttxrend-ttml for forcing center-alignment of TTML texts. Moving towards a single source for all variants, we have to move this into runtime. The solution here is to pass a list of TTML style attributes to the TtmlController. They will make it into the DocumentInstance and be applied to all texts displayed.
RDKEMW-3517 : subttxrend-app uses subttxrend-ctrl
RDKEMW-4075: Enable TTML override on runtime instead of buildtime
Subtec refactored for TextTrack usage and new style override API for TTML styling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.