Repository navigation
Conversation
…layer) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Simek
reviewed
Nov 9, 2026
Simek
approved these changes
Nov 9, 2026
Simek
left a comment
Member
There was a problem hiding this comment.
Hey @marcandrevigneault, thanks for the context and update! 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Why & how
react-native-webrtcis listed as "Untested on New Architecture". The entry has nonewArchitecturefield, and automatic detection can't find it because the package ships nocodegenConfig: it is a legacy native module and view that runs through React Native's interop layer. Sonpx expo-doctorreports it as untested in every project that uses it, although it works.This PR sets
newArchitecture: truewith a note. It follows the README's guidance ("SetnewArchitecturefield only when automatic architecture detection fails for your package, despite it supports the New Architecture") and matches the existing@livekit/react-native-webrtcentry, a fork of the same library that is already marked this way.Evidence
RTCViewmay render beforeMediaStream.addTrackhas finished). It is a timing issue in a view, not a failure to load the module. The note links it so users can judge.✅ Checklist
react-native-libraries.jsonVerify:
bun data:validate(the JSON still validates againstreact-native-libraries.schema.json; checked locally with ajv).🤖 Generated with Claude Code