Skip to content

fix(CSSTransition): avoid undefined class when appearDone is omitted #938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Aminark wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(CSSTransition): avoid undefined class when appearDone is omitted #938

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
90d5bc7
fix(CSSTransition): avoid undefined class when appearDone is omitted
Aminark Oct 25, 2026
b82deb2
test(CSSTransition): cover enterDone without appearDone
Aminark Oct 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/CSSTransition.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ class CSSTransition extends React.Component {
const { doneClassName } = this.getClassNames('enter');

if (type === 'appear' && phase === 'done' && doneClassName) {
className += ` ${doneClassName}`;
className = className ? `${className} ${doneClassName}` : doneClassName;
}

// This is to force a repaint,
Expand Down
59 changes: 31 additions & 28 deletions test/CSSTransition-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,34 +203,37 @@ describe('CSSTransition', () => {
expect(nodeRef.current.className).toBe('appear-test-enter-done');
});

it('should not add undefined when appearDone is not defined', async () => {
const nodeRef = React.createRef();
let done = false;
render(
<CSSTransition
timeout={10}
nodeRef={nodeRef}
classNames={{ appear: 'appear-test' }}
in={true}
appear={true}
onEnter={(isAppearing) => {
expect(isAppearing).toEqual(true);
expect(nodeRef.current.className).toEqual('appear-test');
}}
onEntered={(isAppearing) => {
expect(isAppearing).toEqual(true);
expect(nodeRef.current.className).toEqual('');
done = true;
}}
>
<div ref={nodeRef} />
</CSSTransition>
);

await waitFor(() => {
expect(done).toEqual(true);
});
});
it.each(['', 'enter-done'])(
'should not add undefined when appearDone is omitted and enterDone is %s',
async (enterDone) => {
const nodeRef = React.createRef();
let done = false;
render(
<CSSTransition
timeout={10}
nodeRef={nodeRef}
classNames={{ appear: 'appear-test', enterDone }}
in={true}
appear={true}
onEnter={(isAppearing) => {
expect(isAppearing).toEqual(true);
expect(nodeRef.current.className).toEqual('appear-test');
}}
onEntered={(isAppearing) => {
expect(isAppearing).toEqual(true);
expect(nodeRef.current.className).toEqual(enterDone);
done = true;
}}
>
<div ref={nodeRef} />
</CSSTransition>
);

await waitFor(() => {
expect(done).toEqual(true);
});
}
);

it('should not be appearing in normal enter mode', async () => {
let count = 0;
Expand Down