Fix thin client connection error during slow download

[msivasubramaniaan]

fixes https://redhat.atlassian.net/browse/CRW-11670

Fixed a premature JetBrains Client connection failure during client binary download on slow network connections.

The connection wait now checks thinClient.clientPresent before considering a presence change as a successful client startup. This prevents intermediate presence changes during the download process from triggering Connection Error / Cannot launch client popups. Also added a check for the case where the client is already present before the presence listener is registered.

Additionally resolved the warnings of the file

[coderabbitai]

Important

• 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

• Configuration used: Organization UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: 33afab6a-b61d-4fbe-8c5a-254bdbff4511

---

_{Comment @coderabbitai help to get the list of available commands.}

[codecov-commenter]

Codecov Report

❌ Patch coverage is 34.78261% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 40.59%. Comparing base (71098f6) to head (f62ffa5).
⚠️ Report is 438 commits behind head on main.

Files with missing lines	Patch %	Lines
...com/redhat/devtools/gateway/DevSpacesConnection.kt	47.05%	7 Missing and 2 partials ⚠️
...at/devtools/gateway/DevSpacesConnectionProvider.kt	0.00%	5 Missing ⚠️
.../gateway/view/steps/DevSpacesWorkspacesStepView.kt	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##            main     #366       +/-   ##
==========================================
+ Coverage   0.00%   40.59%   +40.59%     
==========================================
  Files          4      123      +119     
  Lines         26     5318     +5292     
  Branches       0     1018     +1018     
==========================================
+ Hits           0     2159     +2159     
- Misses        26     2866     +2840     
- Partials       0      293      +293     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[adietish]

@msivasubramaniaan can you please add (CRW-11670) to the commit message (ex. "Fix thin client connection error during slow download (CRW-11670)")? That helps to identify the jira issue when looking at the commits. Thanks

[adietish]

@msivasubramaniaan: Your fix is solid. It looks to me though as if the issue still happens: Playing around with it while clearing the client cache, made me hit the issue. Investigating.

[adietish]

The PR is not fixing the issue for me. It looks to me as if the changes are not sufficient: when the connection drops it needs to be reestablished, the download retried.

[msivasubramaniaan]

Hello @adietish,
Please have a look with the latest code. Here I have recorded the video of downloading, the download time almost 4 mins under 3MB/s and the connection error issue was resolved

CRW-11670.mp4

[adietish]

rebased it.

[adietish]

Awesomeness, now things work. Thanks!
Amended minor additional fixes.