Repository navigation
fix(rhdh-base-images): push catalog builder edits when header resolution fails [main] - #144
Merged
Merged
Conversation
…ion fails A FROM or rhocp rewrite of builder.Containerfile was left uncommitted when Node headers could not be resolved. The next branch checkout then aborted, and weekly never opened a GitLab MR. https://redhat.atlassian.net/browse/RHIDP-17793 Generated-by: cursor Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
builder.ContainerfileFROM onmain, then returned when Node header resolution failed. The file stayed dirty, so checkout ofrelease-2.1aborted and weekly never opened a GitLab MR.builder.Containerfileon that failure path (and when the file has no ubi nodejs FROM).commit_push_pathslands it onchore/automated-update-rpm-lockfile/<branch>, which weekly already turns into a GitLab MR when HEAD ischore/*.Test plan
bash -nandshellcheck --severity=warningonbase-images-and-rpms.shuv run ruff checkontests/unit/test_base_images_and_rpms.pyuv run pytest tests/unit/test_base_images_and_rpms.py(43 passed)SKILL_SCRIPT_SHAin midstreambuild/ci/weekly-maintenance.sh. The failing job still fetched4e2960ff7c2d23eca3a4ef8c7ee7121c6fe7ca84.https://redhat.atlassian.net/browse/RHIDP-17793
Generated-by: cursor