[haigou-web]

Closes #2023

Problem

CodeUtil.runTests() deleted EXTENSION_DEV_PATH whenever coverage was off:

if (this.coverage) {
	process.env.EXTENSION_DEV_PATH = process.cwd();
} else {
	delete process.env.EXTENSION_DEV_PATH;
}

EXTENSION_DEV_PATH is documented in guides/test-setup.md as a supported environment variable, and it is the only thing that makes VSBrowser add --extensionDevelopmentPath to the launch arguments. Deleting it meant a value the caller had exported never reached VS Code, so extest run-tests could not run tests against a compiled extension — the commands the extension contributes were simply absent, as reported in the issue.

Fix

The environment preparation moved into applyExtensionDevPath(), which writes the variable only when coverage is enabled and otherwise leaves the caller's value untouched:

export function applyExtensionDevPath(coverage: boolean | undefined, cwd: string, env: NodeJS.ProcessEnv = process.env): void {
	if (coverage) {
		env.EXTENSION_DEV_PATH = cwd;
	}
}

extest setup-and-run --coverage keeps winning, because in that mode the instrumented extension really is the one in the working directory.

Tests

Five unit tests in codeUtil.test.ts cover the new function:

applyExtensionDevPath
  √ keeps a user-supplied EXTENSION_DEV_PATH when coverage is off
  √ leaves EXTENSION_DEV_PATH absent when neither coverage nor the user set it
  √ overrides a user-supplied EXTENSION_DEV_PATH with the working directory when coverage is on
  √ sets EXTENSION_DEV_PATH from the working directory when coverage is on and the user set nothing
  √ mutates only EXTENSION_DEV_PATH

5 passing

Full unit suite: 157 passing, 2 pending via npx tsc -p ./ && npx mocha 'out/test/**/*.test.js'.

Docs

guides/test-setup.md now says the variable is honoured on every run and that --coverage overrides it, instead of leaving that conflict implicit.

Notes for reviewers

• I could not run the UI suite (npm run test:build) — it needs a real VS Code plus ChromeDriver. The change only affects the environment handed to the runner, and the unit tests exercise it directly.
• EXTENSION_DEV_PATH has exactly one reader (VSBrowser), so dropping the delete cannot affect other code paths.
• Unrelated, found while building on Windows and left alone: packages/extester's build script runs chmod a+x ./out/cli.js, which does not exist on Windows, so npm run build fails there even on a clean checkout.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[djelinek]

Thank you for your contribution!

[kurmasz]

Thanks for the fix.