Remove enableNewSecurityPage feature flag - #2604
Open
jvorcak wants to merge 2 commits into
Open
Conversation
The new security page is now the only implementation. Collapses the old/new dispatcher components down to the new ones, deletes the resulting dead legacy code and routes, and removes the E2E specs that existed solely to force the old UI via the flag.
Contributor
🚨 Registry drift detectedApp:
Components needing attention
Refresh command: bunx shadcn@latest add @redpanda/combobox --overwriteGenerated by lookout audit-changes. |
Re-ports the ACL/permissions/user-management/deep-link E2E specs that were dropped when enableNewSecurityPage was removed, targeting the new UI directly instead of forcing the legacy one via the flag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
enableNewSecurityPageis removed fromFEATURE_FLAGSand allisFeatureFlagEnabled('enableNewSecurityPage')branches.AclsTab,RolesTab,UsersTab,PermissionsListTab,RoleDetailPage,UserDetailsPage,SecurityLayout,SecurityTabsNav,AclDetailPage, plus links inoverview.tsxandadd-user-step.tsx) down to the new implementation, deleting the now-dead legacy components.acl-create-page.tsx+ its test,acl-update-page.tsx,role-update-page.tsx) and simplified their route files to unconditional redirects.acl-page.ts/role-page.tspage objects) that existed solely to force the old UI viatest.use({ featureFlags: { enableNewSecurityPage: false } }). Accepting this as a known E2E coverage gap rather than porting them to the new UI.Test plan
bun run type:checkbun run lintbun run test:unit(828 tests passing)bun run test:integration(1246 tests passing)