Repository navigation
charts/redpanda, multicluster: deduplicate RBAC - #1922
Merged
Merged
Conversation
chrisseto
added this pull request to stack #1882
September 25, 2026 19:34
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
chrisseto
changed the title
chrisseto
force-pushed
the
chris/dedup-rbac
branch
from
September 25, 2026 19:59
aead708 to
1b6e796
Compare
chrisseto
force-pushed
the
chris/dedup-rbac
branch
from
September 30, 2026 19:15
1b6e796 to
e7dd2bd
Compare
chrisseto
force-pushed
the
chris/dedup-rbac
branch
from
September 30, 2026 20:30
e7dd2bd to
74821f2
Compare
chrisseto
force-pushed
the
chris/dedup-rbac
branch
from
October 9, 2026 17:05
74821f2 to
8b60212
Compare
chrisseto
marked this pull request as ready for review
October 9, 2026 17:26
chrisseto
requested review from
RafalKorepta,
andrewstucki,
gene-redpanda and
hidalgopl
as code owners
October 9, 2026 17:26
RafalKorepta
approved these changes
Oct 9, 2026
Before this change, rules were in YAML files embedded by the chart. gotohelm's shared packages do not support `go:embed`. `RoleSet` moves the rules to Go, so the chart and the operator may one source. The controller-gen output is now a test fixture. A test makes sure that the Go rules and the fixtures are equal. `RoleSet` adds the `metrics-reader` and `stretch-rack-awareness` ClusterRoles for the operator. The chart does not enable them. The chart output does not change.
Replace the operator RBAC functions with `rbacForPool`. Remove these grants. No code uses them: - sidecar `Role`: `pods`, `apps/statefulsets`. - rack-awareness `ClusterRole`: `list` and `watch` on `nodes`. - This removes `stretch-rack-awareness` from the operator too. Additional: - Do not truncate `ClusterRole` names to 63 characters. Truncation can give all `ClusterRole`s the same name. - Copy labels and annotations for each object.
chrisseto
force-pushed
the
chris/dedup-rbac
branch
from
October 12, 2026 14:04
8b60212 to
a531bef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
charts/redpanda: extract RBAC rendering into a shared
RoleSet(104dc30)Before this change, rules were in YAML files embedded by the chart. gotohelm's
shared packages do not support
go:embed.RoleSetmoves the rules to Go, sothe chart and the operator may one source.
The controller-gen output is now a test fixture. A test makes sure that
the Go rules and the fixtures are equal.
RoleSetadds themetrics-readerandstretch-rack-awarenessClusterRoles for the operator. The chart does not enable them. The chart
output does not change.
operator/multicluster: render RBAC through the shared
RoleSet(8b60212)Replace the operator RBAC functions with
rbacForPool.Remove these grants. No code uses them:
Role:pods,apps/statefulsets.ClusterRole:listandwatchonnodes.stretch-rack-awarenessfrom the operator too.Additional:
ClusterRolenames to 63 characters. Truncation cangive all
ClusterRoles the same name.