Repository navigation
Conversation
chrisseto
added this pull request to stack #1882
September 25, 2026 19:34
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
chrisseto
force-pushed
the
chris/dedup-listeners
branch
from
September 25, 2026 19:59
1e4ea0e to
638893e
Compare
chrisseto
force-pushed
the
chris/dedup-listeners
branch
2 times, most recently
from
September 30, 2026 20:30
4aeef8b to
2b96f5a
Compare
|
This PR is stale because it has been open 5 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
The chart and the stretch-cluster renderer each carried a full copy of listener resolution: what Redpanda binds, what Kubernetes exposes, which certificate each endpoint serves, and which truststore it trusts. `PKI` stopped short of truststores because one belongs to a listener, not a certificate; this is what unblocks that. `charts/redpanda/listeners.go` is now the single IR. An `APIKind` enum keys it and derives every redpanda.yaml key an API renders under; `Listeners` maps kind to `API`, and the four traversal orders -- config, truststores, ports, gateways -- are `[]APIKind`. They disagree, deliberately, and each is pinned to rendered output. Listener TLS resolves against the shared `PKI`, so a keypair is named once. Both renderers translate their own values into the IR once per render (`resolveListeners`) and render from it. Not output neutral: - `rpc_server_tls.truststore_file` was written but the file was never projected. RPC now takes part in truststore projection like any other listener. - Service ports carry `appProtocol` and an explicit `targetPort`. The old gateway/NodePort paths emitted `targetPort: 0`, which the API server defaulted to `port`, so this is inert on the cluster but visible in goldens. - `<api>_tls: null` is no longer emitted for an API serving no TLS.
chrisseto
force-pushed
the
chris/dedup-listeners
branch
from
October 9, 2026 17:05
2b96f5a to
43ebff4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The chart and the stretch-cluster renderer each carried a full copy of listener resolution: what Redpanda binds, what Kubernetes exposes, which certificate each endpoint serves, and which truststore it trusts.
PKIstopped short of truststores because one belongs to a listener, not a certificate; this is what unblocks that.charts/redpanda/listeners.gois now the single IR. AnAPIKindenum keys it and derives every redpanda.yaml key an API renders under;Listenersmaps kind toAPI, and the four traversal orders -- config, truststores, ports, gateways -- are[]APIKind. They disagree, deliberately, and each is pinned to rendered output. Listener TLS resolves against the sharedPKI, so a keypair is named once. Both renderers translate their own values into the IR once per render (resolveListeners) and render from it.Not output neutral:
rpc_server_tls.truststore_filewas written but the file was never projected. RPC now takes part in truststore projection like any other listener.appProtocoland an explicittargetPort. The old gateway/NodePort paths emittedtargetPort: 0, which the API server defaulted toport, so this is inert on the cluster but visible in goldens.<api>_tls: nullis no longer emitted for an API serving no TLS.