Repository navigation
pkg/k3d: re-pull registry images missing from the host before import - #1971
Merged
Merged
Conversation
k3d only imports images the host Docker daemon lists. When none of the requested images are listed, the whole import fails with "no valid images specified". CI pre-pulls every test image, but in #1969's integration job (build 16395) redpandadata/redpanda-operator-nightly disappeared from the daemon between the pre-pull and TestIntegrationFactoryOperatorV1's import, and the test failed on every re-run. Pull any registry image the daemon doesn't list right before importing it.
david-yu
requested review from
RafalKorepta,
andrewstucki,
chrisseto,
gene-redpanda and
hidalgopl
as code owners
October 9, 2026 17:39
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
RafalKorepta
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestIntegrationFactoryOperatorV1failed on every re-run in #1969 (build 16395) withImage 'redpandadata/redpanda-operator-nightly:…' is not a file and couldn't be found in the container runtime/no valid images specified.test:pull-imageshad pulled the image and verified it, but it was gone from the host daemon two minutes later. k3d only imports images the daemon lists.importImagesnow runsdocker pullon any registry image the daemon doesn't list, just beforek3d image import. Images that are already present aren't touched.localhost/images aren't affected because they can't be pulled.TestIntegrationImportRepullsMissingImageremoves an image from the host and then imports it. Run locally, it fails with the CI error without the fix and passes with it.