EPMRPP-118043 || Add scrolling on maintenance page for small screens - #43
Conversation
WalkthroughThe maintenance empty state now enables vertical scrolling when the viewport height is 720px or less. It updates the behavior on resize and removes the listener and inline styling during cleanup. ChangesMaintenance layout behavior
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@ui/src/components/emptyStateMaintenance/emptyStateMaintenance.tsx`:
- Around line 47-66: Update the effect around handleResize to capture the
layoutContentElement’s original overflow-y value and priority before any
mutation, then restore both on cleanup and when the viewport exceeds
MAXIMAL_HEIGHT instead of removing the property unconditionally.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: a6480301-24bf-45ec-9906-65a87704720e
📒 Files selected for processing (1)
ui/src/components/emptyStateMaintenance/emptyStateMaintenance.tsx
Description
Add scrolling to the Maintenance page for small screens
Visuals
EPMRPP-118043.mp4
Summary by CodeRabbit