Skip to content

EPMRPP-118043 || Add scrolling on maintenance page for small screens - #43

Merged
siarheirazuvalau merged 2 commits into
developfrom
bugfix/EPMRPP-118043
Aug 11, 2026
Merged

siarheirazuvalau merged 2 commits into
developfrom
bugfix/EPMRPP-118043

Conversation

@siarheirazuvalau

@siarheirazuvalau siarheirazuvalau commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Description

Add scrolling to the Maintenance page for small screens

Visuals

EPMRPP-118043.mp4

Summary by CodeRabbit

  • Bug Fixes
    • Improved layout behavior on short screens by enabling vertical scrolling when the viewport height is 720px or less.
    • Updated scrolling automatically when the window is resized.
    • Restored the layout’s original styling when leaving the page.

@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown

Review Change Stack

Walkthrough

The maintenance empty state now enables vertical scrolling when the viewport height is 720px or less. It updates the behavior on resize and removes the listener and inline styling during cleanup.

Changes

Maintenance layout behavior

Layer / File(s) Summary
Viewport overflow handling
ui/src/components/emptyStateMaintenance/emptyStateMaintenance.tsx
The component adds a maximum-height threshold and a resize effect. Short viewports receive overflow-y: auto !important; taller viewports remove the override. The effect exits when the target element is absent and cleans up on unmount.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: allaprischepa, vahesamsonyan

Poem

A rabbit checks the window height,
And makes the narrow content right.
Scrollbars hop when space is small,
Resize listeners heed the call.
On unmount, the trails depart.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: adding scrolling to the Maintenance page for small screens.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch bugfix/EPMRPP-118043

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@ui/src/components/emptyStateMaintenance/emptyStateMaintenance.tsx`:
- Around line 47-66: Update the effect around handleResize to capture the
layoutContentElement’s original overflow-y value and priority before any
mutation, then restore both on cleanup and when the viewport exceeds
MAXIMAL_HEIGHT instead of removing the property unconditionally.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: a6480301-24bf-45ec-9906-65a87704720e

📥 Commits

Reviewing files that changed from the base of the PR and between 92fc066 and ecc9317.

📒 Files selected for processing (1)
  • ui/src/components/emptyStateMaintenance/emptyStateMaintenance.tsx

Comment thread ui/src/components/emptyStateMaintenance/emptyStateMaintenance.tsx
@siarheirazuvalau
siarheirazuvalau merged commit f89c306 into develop Aug 11, 2026
3 checks passed
@siarheirazuvalau
siarheirazuvalau deleted the bugfix/EPMRPP-118043 branch August 11, 2026 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants