Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix SVG/PDF rendering for reMarkable v6 explicit RGBA stroke colours parsed by
rmsceneasLine.color_rgba.Previously, explicit RGBA tuples such as
(48, 74, 224, 77)were emitted directly as CSSrgba(48, 74, 224, 77). CSS alpha is not an 8-bit channel, so those strokes render incorrectly. This patch separates colour and opacity:rgb(r, g, b)a / 255It also avoids applying an extra hard-coded fade to v6
SHADERstrokes because the file already carries opacity incolor_rgba.Verification
svg_rgb,svg_alpha, normal pen opacity, and shader opacity..rmsample containing shader colours and confirmed generated SVG now contains valid CSS like:instead of invalid 8-bit alpha in
rgba(...).