fix: broken user group table infinite query - #9793
Merged
Merged
Conversation
AdityaHegde
force-pushed
the
fix/user-group-table-infinite-query
branch
from
August 6, 2026 05:08
50cdc4f to
64c4218
Compare
nishantmonu51
approved these changes
Aug 7, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes pagination behavior in the organization User Groups page by switching the underlying data fetch from a single-page query (that replaced results) to an infinite query that retains all previously loaded pages.
Changes:
- Update the user groups route to consume an infinite query and aggregate
pages[]into one list for filtering/rendering. - Add a
getOrgUsergroupsInfiniteselector to centralize the infinite-query configuration and next-page token handling. - Update Orval-generated client/query helpers and Orval config to support an infinite query variant for listing org member usergroups.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| web-admin/src/routes/[organization]/-/users/groups/+page.svelte | Switch groups page to infinite query, flatten paged results, and trigger fetchNextPage() on load-more. |
| web-admin/src/features/organizations/user-management/selectors.ts | Add getOrgUsergroupsInfinite selector wrapping the new Orval infinite query helper. |
| web-admin/src/client/gen/default/default.ts | Generated: add infinite-query key/options + createAdminServiceListOrganizationMemberUsergroupsInfinite. |
| web-admin/orval.config.ts | Enable useInfinite generation for AdminService_ListOrganizationMemberUsergroups. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
AdityaHegde
added a commit
that referenced
this pull request
Aug 7, 2026
* fix: broken user group table infinite query * PR comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User group table queried a new page each time replacing the old one. Updated to use infinite queries so that all pages are retained.
Closes APP-923
Checklist: