Conversation
Previously if `x-select-request-type` was nil, `simpleclip-get-contents` would
decode Unicode characters as Latin-1. E.g. copying "🙂" and calling
`simpleclip-get-contents` would return:
```
\#("\\U0001f642" 0 10 (foreign-selection nil))
```
The fix mirrors `gui--selection-value-internal` as mentioned in the
previous TODO comment by trying UTF8_STRING, COMPOUND_TEXT,
STRING, and `text/plain;charset=utf-8' in order.
Full disclosure: this was produced with *heavy* assistance from LLMs,
but I reviewed and tested it to the best of my abilities, and it works
fine for me on Emacs 30.2 and (X)Wayland. `make test` passes.
Fixes rolandwalker#23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously if
x-select-request-typewas nil,simpleclip-get-contentswould decode Unicode characters as Latin-1. E.g. copying "🙂" and callingsimpleclip-get-contentswould return:The fix mirrors
gui--selection-value-internalas mentioned in the previous TODO comment by trying UTF8_STRING, COMPOUND_TEXT, STRING, andtext/plain;charset=utf-8in order.Full disclosure: this was produced with heavy assistance from LLMs, but I reviewed and tested it to the best of my abilities, and it works fine for me on Emacs 31.1 and (X)Wayland.
make testpasses.Fixes #23
(Thanks for the great package! It's addressing some insane clipboard behavior for me on Wayland. 😓)