fix(bash): return when the shell exits, not when its pipes close - #35
Merged
Merged
Conversation
A background process (`sleep 40 &`, `server &`) inherits stdout/stderr, so waiting for pipe EOF blocked the tool until it exited - forever for a server, since bash has no default timeout. Mirror pi's waitForChildProcess: after the shell exits, keep reading until the pipes close or stay quiet for 100 ms (re-armed by every chunk), then stop reading and close our pipe ends. Fixes #23 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A background process (
sleep 40 &,server &) inherits stdout/stderr, so waiting for pipe EOF blocked the tool until it exited - forever for a server, since bash has no default timeout. Mirror pi's waitForChildProcess: after the shell exits, keep reading until the pipes close or stay quiet for 100 ms (re-armed by every chunk), then stop reading and close our pipe ends.Fixes #23