Retry transport failures and name their cause - #40
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #39
RETRYABLE_PATTERNS. The list was ported from pi and uses Node's fetch wording, so reqwest transport failures never matched it, and the turn ended instead of auto-retrying. Two phrases are added:error sending request: nothing came back. This is pi'sfetch failed.error decoding response body: the SSE stream broke mid-response. This is pi'sterminated.source()chain inInferenceError::Http, so the retry notice and the session file say why the request failed. Example:…error sending request for url (…): client error (SendRequest): connection error: Connection reset by peer (os error 54). This deviates from pi, whose message is onlyfetch failed.transient_errors_are_retryable. The newtransport_errors_name_their_causechecks that a refused connection mentionsConnection refused.End-to-end check (a throwaway test, not committed): the real Codex provider and agent loop ran against a local server that resets the first connection.
A reset in the middle of the SSE stream gave the same result.
Validation:
cargo fmt --check;cargo clippy --workspace --all-targets -- -D warnings;cargo test --workspace(436 passed).🤖 Generated with Claude Code