Skip to content

feat: add a security-advisories action shared by coop and osprey - #20

Merged
reitblatt merged 1 commit into
mainfrom
reitblatt/security-advisories-action
Nov 10, 2026
Merged

reitblatt merged 1 commit into
mainfrom
reitblatt/security-advisories-action

Conversation

@reitblatt

@reitblatt reitblatt commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

See #19 for broader context.

tl;dr: since Github actions don't support security advisories, we have to periodically poll the API to support them. I'm moving the composite action for this into from roostorg/coop#1523 in discord-bot itself so that we can share it across multiple repos (e.g. coop and osprey) instead of duplicating it.

Testing

  • python3 -m unittest discover -s security-advisories: 14 tests pass. They include an end-to-end run of the list and post steps against a fake GitHub API and a fake Discord webhook. That run checks the message text, that mentions are disabled, that nothing is reposted on the next run, and that a Discord error leaks no advisory data to the log.
  • Checked by hand that post.sh still skips draft PRs and still errors on an empty webhook.
  • zizmor 1.25.2 and actionlint report nothing on the new files. zizmor's two existing findings in discord.yml (pull_request_target, @main pin) are unchanged.

Moves the advisory listing, cached HMAC state and posting from coop's
workflow into a composite action, so each repo keeps only a thin caller
workflow with its own environment and secrets. The posting loop moves to
post.sh, shared with the main action. Adds a test workflow and Dependabot
for the action pins.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@reitblatt
reitblatt marked this pull request as ready for review November 10, 2026 00:32
@reitblatt
reitblatt merged commit f86a3b9 into main Nov 10, 2026
3 checks passed
@reitblatt
reitblatt deleted the reitblatt/security-advisories-action branch November 10, 2026 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant